Slide Uploads Don't Require Feeds
Reported by Brian Michalski | February 17th, 2010 @ 12:35 PM | in Concert 1.9.x
Uploading should fail if a feed isn't selected. This doesn't happen at the moment.
Comments and changes to this ticket
-
Brian Michalski February 19th, 2010 @ 09:07 AM
Maybe this isn't a bug... does anyone remember if this is suppose to be a feature?
-
Brian Michalski June 5th, 2010 @ 12:28 PM
- Tag changed from “content, upload” to “content, upload, v1”
-
Kevin Russell July 13th, 2011 @ 10:27 PM
- Milestone order changed from “0” to “0”
It would be hard to imaging that this would be a feature since it leaves the database in a state where the content cannot be approved. Attached is a patch that requires that a feed be selected.
-
Brian Michalski July 17th, 2011 @ 04:57 PM
I can't remember why this might be a feature, so I'll consider it a bug until someone complains otherwise.
The patch looks good, with 2 lines that seem to be a bit out of place - Did you find the duration wasn't being sent correctly and added that default in there to fix that?
-
Kevin Russell July 19th, 2011 @ 01:23 AM
I've submitted a pull request at GitHub with a commit that should prevent the submission of content without at least one feed assigned. The additional 2 lines are not part of this commit. I have a few other commits that address error messages in the logs. In this particular case $dat['duration'] isn't defined before its first use.
-
Brian Michalski July 29th, 2011 @ 02:35 AM
- State changed from “open” to “resolved”
Pull request accepted. This change has been merged into non-cas.
-
Michael DiTore April 29th, 2012 @ 05:39 PM
(from [1bc5457cf04a41366b595e8db33afc5af37567be]) Fixed ConcertoConfig method_missing - closes #72
The super call was causing of problems when using other method missing
methods, such as "find_or_create_by...".
https://github.com/concerto/concerto/commit/1bc5457cf04a41366b595e8...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Concerto is an open source digital signage system that makes it easy to engage a large community of people with graphical and text-based announcements, bulletins, and other messages... but enough about us, you came here to get involved.
<br />
If you think you've <b>found a bug in Concerto</b>, please click 'Create new ticket' and let us know about it.
<br />
Looking to peek at our source code? Head to <a href="https://github.com/concerto/concerto_v1">https://github.com/concerto/concerto_v1</a> (Concerto version 1) or <a href="https://github.com/concerto/concerto">https://github.com/concerto/concerto</a> (Concerto version 2).
<br />
Our getting started guide is available here: <a href="https://github.com/concerto/concerto/wiki/Getting-Involved">https://github.com/concerto/concerto/wiki/Getting-Involved</a>.
Brian Michalski
Brian R Zaik
Haris Khan
Kevin Russell