Slide Uploads Don't Require Feeds
-
Brian MichalskiMaybe this isn't a bug... does anyone remember if this is suppose to be a feature?
-
-
Kevin Russell- Milestone order changed from 0 to 0
It would be hard to imaging that this would be a feature since it leaves the database in a state where the content cannot be approved. Attached is a patch that requires that a feed be selected.
-
null-feed.diff
3.08 KB
-
Brian Michalski
I can't remember why this might be a feature, so I'll consider it a bug until someone complains otherwise.
The patch looks good, with 2 lines that seem to be a bit out of place - Did you find the duration wasn't being sent correctly and added that default in there to fix that?
-
Kevin Russell
I've submitted a pull request at GitHub with a commit that should prevent the submission of content without at least one feed assigned. The additional 2 lines are not part of this commit. I have a few other commits that address error messages in the logs. In this particular case $dat['duration'] isn't defined before its first use.
-
Brian Michalski
- State changed from open to resolved
Pull request accepted. This change has been merged into non-cas.
-
Michael DiTore
(from [1bc5457cf04a41366b595e8db33afc5af37567be]) Fixed ConcertoConfig method_missing - closes #72 Slide Uploads Don't Require Feeds
The super call was causing of problems when using other method missing
methods, such as "find_or_create_by...".
https://github.com/concerto/concerto/commit/1bc5457cf04a41366b595e8...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.