Redesign Template Importing
Reported by Brian Michalski | June 14th, 2011 @ 04:37 PM | in Basic Functional Workflow [Concerto2]
We can't rely on the Hash::from_xml and then each_pair function to process the keys in the correct order. We have to make sure that top, left, bottom, and right are processed BEFORE width and height are. Right now that order is completely random (I think).
Perhaps this re factoring involves pulling import_xml into the Position model, so each Position loads it's own XML.
++ needs unit testing too
Comments and changes to this ticket
-
Brian Michalski June 15th, 2011 @ 02:55 AM
- State changed from “new” to “resolved”
- Assigned user set to “Brian Michalski”
(from [37da7a00cf80a19af38a88e7b832f4a524c903b2]) Refactoring template importing. I think I'm satisfied with this. [#155 state:resolved responsible:"Brian Michalski"] https://github.com/concerto/concerto/commit/37da7a00cf80a19af38a88e...
-
Brian Michalski June 15th, 2011 @ 02:57 AM
Actually, we could use some more unit testing if someone is feeling inclined. It'd be cool to test a template hash with a) no fields b) >1 fields.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Concerto is an open source digital signage system that makes it easy to engage a large community of people with graphical and text-based announcements, bulletins, and other messages... but enough about us, you came here to get involved.
<br />
If you think you've <b>found a bug in Concerto</b>, please click 'Create new ticket' and let us know about it.
<br />
Looking to peek at our source code? Head to <a href="https://github.com/concerto/concerto_v1">https://github.com/concerto/concerto_v1</a> (Concerto version 1) or <a href="https://github.com/concerto/concerto">https://github.com/concerto/concerto</a> (Concerto version 2).
<br />
Our getting started guide is available here: <a href="https://github.com/concerto/concerto/wiki/Getting-Involved">https://github.com/concerto/concerto/wiki/Getting-Involved</a>.
People watching this ticket
Brian Michalski
Haris Khan
Michael DiTore
Tags
Referenced by
-
155
Redesign Template Importing
(from [37da7a00cf80a19af38a88e7b832f4a524c903b2])
Refacto...