Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Redesign Template Importing

#155

We can't rely on the Hash::from_xml and then each_pair function to process the keys in the correct order. We have to make sure that top, left, bottom, and right are processed BEFORE width and height are. Right now that order is completely random (I think).

Perhaps this re factoring involves pulling import_xml into the Position model, so each Position loads it's own XML.

++ needs unit testing too

Reported by Brian Michalski · June 14th, 2011 @ 04:37 PM

State: resolved
Milestone: Basic Functional Workflow [Concerto2]
Assigned to: Brian Michalski Brian Michalski

Activity

  1. Brian Michalski
    Brian Michalski
    • State changed from new to resolved
    • Assigned user set to Brian Michalski

    (from [37da7a00cf80a19af38a88e7b832f4a524c903b2]) Refactoring template importing. I think I'm satisfied with this. [#155 Redesign Template Importing state:resolved responsible:"Brian Michalski"] https://github.com/concerto/concerto/commit/37da7a00cf80a19af38a88e...

    June 15th, 2011 @ 02:55 AM

  2. Brian Michalski
    Brian Michalski

    Actually, we could use some more unit testing if someone is feeling inclined. It'd be cool to test a template hash with a) no fields b) >1 fields.

    June 15th, 2011 @ 02:57 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.