Start / End Time translation breaks in Ruby 1.9.2
Reported by Brian Michalski | April 13th, 2011 @ 02:28 AM
You can't create content in Ruby 1.9.2. The start_time and end_time attribute accessors attempt to parse a hash into a date but this fails in Ruby 1.9.2.
ArgumentError in ContentsController#create
argument out of range
Rails.root: /Users/bamnet/Documents/work/concerto
Application Trace | Framework Trace | Full Trace
app/models/content.rb:51:in end_time='
app/controllers/contents_controller.rb:77:innew'
app/controllers/contents_controller.rb:77:in `create'
Request
Parameters:
{"utf8"=>"✓", "authenticity_token"=>"h7Ea8Z0IvEPedkITESQ1ucXHDAQOiru6Vh3+/+PylXg=", "ticker"=>{"data"=>"This is a test", "name"=>"", "duration"=>"8", "start_time"=>{"date"=>"04/12/2011", "time"=>"12:00 am"}, "end_time"=>{"date"=>"04/20/2011", "time"=>"11:59 pm"}, "user_id"=>"1"}, "type"=>"Ticker", "commit"=>"Create Ticker"}
Comments and changes to this ticket
-
August April 15th, 2011 @ 12:19 AM
- State changed from “open” to “resolved”
- Assigned user changed from “Brian Michalski” to “August”
Ruby 1.9 deliberately changed this behavior to comply with Euro/ISO standards. Using strptime and specifying the conventions being used seems to have worked. Committed.
-
Brian Michalski April 15th, 2011 @ 11:59 AM
- State changed from “resolved” to “open”
I'm going to open this up for now, I have an offending test case I want to commit and not forget about. Small nuances like this in Ruby versions could definitely come back to haunt us later if we forget about them...
-
Brian Michalski April 25th, 2011 @ 07:40 PM
- State changed from “open” to “resolved”
(from [c7c603245cd52776afb228006109af83695843bb]) Adding a test case for [#134 state:resolved], also resolving a 1.8.7 bug (Time doesn't have strptime). https://github.com/wtg/concerto/commit/c7c603245cd52776afb228006109...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Concerto is an open source digital signage system that makes it easy to engage a large community of people with graphical and text-based announcements, bulletins, and other messages... but enough about us, you came here to get involved.
<br />
If you think you've <b>found a bug in Concerto</b>, please click 'Create new ticket' and let us know about it.
<br />
Looking to peek at our source code? Head to <a href="https://github.com/concerto/concerto_v1">https://github.com/concerto/concerto_v1</a> (Concerto version 1) or <a href="https://github.com/concerto/concerto">https://github.com/concerto/concerto</a> (Concerto version 2).
<br />
Our getting started guide is available here: <a href="https://github.com/concerto/concerto/wiki/Getting-Involved">https://github.com/concerto/concerto/wiki/Getting-Involved</a>.
People watching this ticket
August
Brian Michalski
Haris Khan
Referenced by
-
134
Start / End Time translation breaks in Ruby 1.9.2
(from [c7c603245cd52776afb228006109af83695843bb])
Adding ...