Aspect Ratio Identification
-
Zach Roweare we only interested in 4:3 vs 16:9, or should we identify other aspects as well
-
Brian MichalskiGood queston Zach. 4:3 and 16:9 are the two we definitely need to support.
I could see a use for recognizing 9:16 displays (like a portrait monitor)
but I don't know how critical that use is. Perhaps we can simple add a
fraction into an array somewhere (like this new method?) telling it what
sizes it should recognize... -
Haris KhanThere would also be value in 16:10 ratios (ie computer displays)
-
Zach Rowe
so does it make sense to store the ratio separately? I 'm trying to think end-to-end, what would be the best way to retrieve such information. We could store the value pair, and do computation in the screens controller
-
Brian Michalski
- Assigned user set to Zach Rowe
- State changed from new to open
(from [69043b31ddac8712f157b1852b8582859c8f30ee]) storing screen resolution, calculating aspect ratio [#131 Identify Screen Aspect Ratio state:open assigned:'Zach Rowe'] [#111 Aspect Ratio Identification state:open assigned:'Zach Rowe'] https://github.com/wtg/concerto/commit/69043b31ddac8712f157b1852b85...
-
Brian Michalski
- Tag changed from v2 to screen, v2
-
Brian Michalski
Zach - Any chance you want to write a test case to go along with this? If you do, I think we can mark this resolved. If you'd rather I write the test that's fine to, just let me know!
-
Brian Michalski
- State changed from open to resolved
(from [867b52e56b1084aa26b549667de9fef71347542e]) added test for aspect ratio [#111 Aspect Ratio Identification state:resolved] https://github.com/concerto/concerto/commit/867b52e56b1084aa26b5496...
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.